Siyao (Jane) He

Results 18 comments of Siyao (Jane) He

We explored several alternatives for unit testing this memory leak fix but decided to give up testing it, as we could not find a reliable way to test the garbage...

We still need to figure out how `NodeStateEvent` and `DistanceEvent` refer to their `node`. Other than that, the update PR should have resolved all the other issues.

Solved the `NodeState` and `NodeDistance` problem as discussed. All the issues should be resolved now. I would appreciate a review :)

May you please merge apache/4.x to your branch?

We realize that `RequestTracker.getErrors` was used for ["errors from previous coordinators"](https://github.com/apache/cassandra-java-driver/blob/811acb2fe77464f679a09226a03c1995694c51b4/core/src/main/java/com/datastax/oss/driver/api/core/cql/ExecutionInfo.java#L105-L114). We want to discuss whether we should still stick to that. I started the conversation in the ASF slack...

The revapi thing is fixed and the vector similarity function is already supported by the existing `Function` term. I added tests for it as examples: https://github.com/apache/cassandra-java-driver/blob/19148d5cb9e2e2975a4d503358e9fae8737e0fcc/query-builder/src/test/java/com/datastax/oss/driver/api/querybuilder/select/SelectSelectorTest.java#L235-L274 In terms of the...

I assume @lukasz-antoniak comment [here](https://github.com/apache/cassandra-java-driver/pull/1952/files#r1793979356) about adding `getAnn()` in `DefaultSelect` should be addressed here. Thank you for your suggestion! It's added.