Sita Lakshmi Sangameswaran
Sita Lakshmi Sangameswaran
Thanks for the review, @Shabirmean :) Agree with the PR splitting strategy. Would be easier for the reviewers. I will be more careful the next time. Thanks for pointing it...
@Shabirmean Thanks for the review. I've incorporated your suggestions. PTAL.
compute/cloud-client/src/main/java/compute/CreateInstanceFromTemplate.java has no test and is broken
Please find the test for the particular snippet here: https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/compute/cloud-client/src/test/java/compute/InstanceTemplatesIT.java#L104-L108 I'll further evaluate and get back why diskType throws an error.
@eaball35 Since we have the updated IAM GAPIC libraries, I am guessing this issue is not valid?
Kindly provision these permissions: roles/compute.instanceAdmin.v1 and roles/compute.storageAdmin TIA!
Thanks @Shabirmean for the review. Addressed all your comments. The class structure was supposed to be in the format you suggested. Looks like the auto code linter had other plans...
Flaky bot raised the issue as the service was temporarily unavailable. Closing this issue as this seems to be transient.
@minherz Ack, but the samples are supporting a new launch. Hence, the priority in adding them.
> * nit: it is generally recommended to narrow the scope of code snippets by placing the region tags around the actual code while omitting `main()` methods and other not...
Blocked by https://github.com/googleapis/testing-infra-docker/pull/342