Simone Rubino
Simone Rubino
The modified method comes from https://github.com/OCA/reporting-engine/commit/d9d2ef5b2731ba312e6274ea162caa2183d0ccbb and https://github.com/OCA/reporting-engine/commit/1f6bb667db1105d7cc33bbad83f27c2aeda7ccb7, maybe the authors @victoralmau and @AaronHForgeFlow would like to have a look?
Rebased on `16.0`
Rebased on `16.0`
> How you do the searching? I tested in the comment template list and I can search by model successfully without this change. Thanks for having a look! I'm searching...
> Just one thing, I think you can add yourself as contributor in the CONTRIBUTORS.rst file Right, thanks, I added myself to CONTRIBUTORS. > changing the copyright requires big changes...
@GuillemCForgeFlow maybe you'd like to have a look? I just noticed you are the maintainer of the module, but for some reason @OCA-git-bot did not mention you.
> LGTM! code and functional review 👍🏿 thank you for adding the test case, helps a lot 😄 Would you like to merge maybe? See how in https://github.com/OCA/oca-github-bot?tab=readme-ov-file#commands.
Rebased on `16.0`
Rebased on `16.0`.
> I tried to write a test for it, but it is not possible with the module in place to test this, as the module itself prevents that. So when...