server-ux icon indicating copy to clipboard operation
server-ux copied to clipboard

Published 20 hours ago • verified publisher icon OCA

[MIG] base_rule_visibility_restriction: Migration to 16.0

Open SirAionTech opened this issue 1 year ago • 2 comments

Standard migration from 14.0 (https://github.com/OCA/server-ux/tree/10d1201c013eb86fc8cf6c3e03fd9676ddbffaf3/base_rule_visibility_restriction).

Added a test for better coverage.

SirAionTech avatar Apr 12 '24 14:04 SirAionTech

@GuillemCForgeFlow maybe you'd like to have a look? I just noticed you are the maintainer of the module, but for some reason @OCA-git-bot did not mention you.

SirAionTech avatar Apr 29 '24 15:04 SirAionTech

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Apr 30 '24 15:04 OCA-git-bot

LGTM! code and functional review 👍🏿 thank you for adding the test case, helps a lot 😄

Would you like to merge maybe? See how in https://github.com/OCA/oca-github-bot?tab=readme-ov-file#commands.

SirAionTech avatar May 28 '24 07:05 SirAionTech

/ocabot merge nobump

GuillemCForgeFlow avatar May 28 '24 07:05 GuillemCForgeFlow

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-859-by-GuillemCForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot avatar May 28 '24 08:05 OCA-git-bot

Congratulations, your PR was merged at e1c04c37d2bb7423713cb766885aace6543f7452. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar May 28 '24 08:05 OCA-git-bot