Pavel Siomachkin comments

Results 11 comments of


                                            Pavel Siomachkin

[encode] Encoding bug when handle_errors is invoked

Here is my proposal to fix this bug. The encode middleware partially initializes compression, but when template processing fails, `errorHandlerChain` reuses the same response writer, resulting in mixed gzip headers...

caddy socket activation (bind fd/N, bind fdgram/N) only works with a single systemd.socket file, limiting configurability

Hi! I've implemented a solution for named socket activation support. Here's what I did: - Added `getFdByName()` function that reads `LISTEN_FDNAMES` environment variable - Extended `ParseNetworkAddressWithDefaults()` to handle fdname/name and...

Confusing behaviour when starting a server on the admin port

Hi! I'm reproducing this issue and can confirm the problem exists, but it's actually even worse than described in the original report. My test setup: Environment: Windows, latest master branch....

Allow Caddy to bind to an interface name (not IP address)

Hi! I propose the following solution for this issue: - Added support for bind "interfaceName" syntax - Supports IP version modes: `bind "eth0:8080:ipv4"`, `bind "eth0:8080:ipv6"`, `bind "eth0:8080:auto"` - first try...

ServerWatchStream can't be closed when client closed watcher

Hi, I'm new to contributing to etcd and have been studying the codebase. I believe I found a solution to the memory leak issue. The memory leak occurs due to...

Combination of ech and a site block for the ech name cannot use tls resolver config

Here's what I found in caddyconfig/httpcaddyfile/tlsapp.go: 1. ECH creates automation policy in `buildTLSApp()` 2. Default issuers are added to ECH policy in `buildTLSApp()` 3. Site block with tls { resolvers...

Combination of ech and a site block for the ech name cannot use tls resolver config

@Gunni I added detailed logging to consolidateAutomationPolicies() and tested both scenarios with a mock DNS provider: Case 1: Does not work ``` { acme_dns mock foo ech example.com } example.com...

listeners: Add network interface binding support, with IP version modes

@Monviech Thanks for the detailed feedback! **Regarding binding to all IPs:** I'm working on adding support for `bind "eth0:8080:all"` to bind to all addresses on an interface, which would address...

listeners: Add network interface binding support, with IP version modes

@Monviech Thanks for the thoughtful feedback! I understand your point about 'all' mode having the least assumptions. However, I believe the single-address modes (ipv4/ipv6/auto) serve important use cases: 1. Simplicity...

listeners: Add network interface binding support, with IP version modes

@francislavoie The `||` delimiter is used internally to encode the interface name and mode into the `NetworkAddress.Host` field. The flow is: 1. User writes: `bind "eth0:8080:ipv4"` in Caddyfile 2. `parseInterfaceAddress()`...