Simon Heimberg
Simon Heimberg
implementation mentioned above https://github.com/php-censor/php-censor/issues/114#issuecomment-324801286 handles the mirror repo automatically * Maintaining a mirror is another possibility of course. This requires managing this mirror repo (create, pull into, delete when project...
Some ideas: - distinguish between workflow and action: - workflow has top level keys `jobs` and `on` - action has top level key `runs` - find action files: - maybe...
To kick the worker from the building, there just needs to be code for an evict button near https://github.com/widelands/widelands/blob/40df522/src/wui/constructionsitewindow.cc#L149 which would trigger a function which evicts the builder if it...
Possible related failure of an assertion: `/home/wl/src/src/scripting/persistence.cc:214: uint32_t persist_object(lua_State*, FileWrite&, Widelands::MapObjectSaver&): Zusicherung »lua_gettop(L) == 2« nicht erfüllt.` I do not understand what object the state is checked. But it seemed...
> > Well, as far as I can see the only functional change here is that a method that always returned `nil` before now has a `table` return value. This...
> > include "xxx.lua" returns the return value of the script (as was already possible for c code), or an empty table. > > Does "returning an empty table" means...
There is still invalid doc I do not know how to fix: https://github.com/widelands/widelands/pull/6210#pullrequestreview-1719724508 Fixing this would run the tests. Maybe this would show assertion an error like in https://github.com/widelands/widelands/pull/6210#issuecomment-1814631636 ,...
> _[Mirrored from Codeberg](https://codeberg.org/wl/widelands/pulls/4553#issuecomment-1377633)_ _On Wed Dec 13 10:40:29 CET 2023, **Benedikt Straub (Nordfriese)** commented:_ > > Tested and working, Code LGTM. > > I would suggest renaming `no_pop_table` to...
> > Shall I remove those commits? How? (Bunnybot merged back my old branch after a force push, so I am not sure anymore how things work.) > > I'd...
> > _[Mirrored from Codeberg](https://codeberg.org/wl/widelands/pulls/4553#issuecomment-1377633)_ _On Wed Dec 13 10:40:29 CET 2023, **Benedikt Straub (Nordfriese)** commented:_ > > Tested and working, Code LGTM. > > I would suggest renaming `no_pop_table`...