Simon Heimberg

I am surprised to find out that this does not work for most things. As all units need register.lua (in https://www.widelands.org/documentation/add-ons/), I expected all would support to set attributes there....

I guess this just should be: ` - tests/*.py` else the file name must be like tests/xx..py (with two dots). `*` matches one level, `**` matches any level. To try...

alternative for any: `${{ steps.filter.outputs.changes != '[]' }} ` alternative for all: `${{ ! contains(toJSON(steps.filter.outputs), '"false"') }} ` # could fail if an output is named false (which gets listed...

What I suggest is more a way to do it with the current code than an opinion. I will not use those outputs because I have no user provided input...

my win condition addon "time_limitted_peaceful.wad" has a dialogue integrated. As I wrote this is possible today. But the dialogue is disabled because it would desync replays and also network games....

triggered by test/maps/lua_testsuite.wmf/scripting/test_lua_in_game.lua https://github.com/widelands/widelands/blob/2fea818ff683354050a289f719fe89b744e573d1/src/scripting/lua_map.cc#L1077 ### crash log https://github.com/SimonHeimberg/widelands/actions/runs/15968125626/job/45033017140?pr=18#step:8:1677 ``` Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x56508b543361 in operator new(unsigned long) (/home/runner/work/widelands/widelands/build/src/widelands+0x1155361) (BuildId: c28ced84fa030d09c5bbecebd4d4089ccbc18d1b) #1 0x56508caf3be4...

triggered by test/maps/plain.wmf/scripting/test_text_renderer_does_not_crash.lua https://github.com/widelands/widelands/blob/2fea818ff683354050a289f719fe89b744e573d1/src/graphic/text/rt_parse.cc#L182 ### crash log https://github.com/SimonHeimberg/widelands/actions/runs/15968125626/job/45033017140?pr=18#step:8:4489 ``` Direct leak of 104 byte(s) in 1 object(s) allocated from: #0 0x55d756785361 in operator new(unsigned long) (/home/runner/work/widelands/widelands/build/src/widelands+0x1155361) (BuildId: c28ced84fa030d09c5bbecebd4d4089ccbc18d1b) #1 0x55d756bc22cb...

looking at crash log in [issue report (not in comment)](#issue-3192766000) - `#1` creates a `new Tag` which is put into class var Tag::_children (which has type `ChildList`), wrapped in `Child()`...

The replay, both files in one zip: [Lake_of_Tranquility__2workers.zip](https://github.com/widelands/widelands/files/11962530/Lake_of_Tranquility__2workers.zip) size: 55k After 40 seconds, two blue carriers leave the HQ for a road being split once only. So one will join...

A 2nd carrier comes if the road is split when the original carrier is on the way (to pick something up) on the 2nd half of the road. There might...