Simon Cropp comments

Results 614 comments of


                                            Simon Cropp

Replace Newtonsoft.Json with System.Text.Json

perhaps u could alias newtonsoft https://github.com/getsentry/dotnet-assembly-alias/ and use the internal option to avoid conflicts for consuming libs

Replace Newtonsoft.Json with System.Text.Json

@AndersMalmgren > Right now Im seriously thinking of moving to nunit just to get rid of newtonsoft. that wont help. nunit still requires Microsoft.NET.Test.Sdk to work. and that refs Microsoft.TestPlatform.TestHost...

Console.WriteLine calls during dotnet test are not emitted to the console on Windows

@chhh that is a design decision by xunit so as to avoid the use of static state. one possible option is to try this approach https://github.com/SimonCropp/XunitLogger which uses asynclocal to...

Console / Trace / Debugger capture support

@bradwilson would be more than happy to donate that code to xunit. or help with a PR

fix DateOnly has current date return 'today'

i agree with @hazzik. closing this one. @ AJacksonCT if you still want this approach, can you re submit as an opt in approach

fix DateOnly has current date return 'today'

ok after re-reading the issue more closely i think i was mistaken in closing this. since dateonly has no time component, it is incorrect to use the phrasing "from now"...

fix DateOnly has current date return 'today'

@AJacksonCT thoughts?

fix DateOnly has current date return 'today'

@clairernovotny do u want to proceed with this?

fix DateOnly has current date return 'today'

@AJacksonCT can you rebase

Investigate using Span

some changes that should facilitate this * netstandard1.0 dropped * Polyfill added to unlock a bunch of new c# syntactical sugar and add some missing apis https://github.com/SimonCropp/Polyfill. let me know...