SimonCockx

Results 46 comments of SimonCockx

I'm on Windows too, actually, so I'm surprised it's not possible to replicate. But yes, I agree it might make things more efficient, and yes, if you can add that...

Fixes https://github.com/finos/common-domain-model/issues/3004

@manel-martos It seems the build is failing. Any idea why?

@manel-martos Looking at the test failures, they do not look like expectation mismatches, but more like some kind of setup issue. ``` Error: Errors: Error: CMEClearedConfirmTest.setup:31 � Runtime Failed to...

Looks good to me! As discussed with @manel-martos in the comments above, something to follow up on in next PR is the formatting of generated json files.

@PayalKhanna @manel-martos Now that the synonyms have been removed, I would like to do a final review, but it will need to be brought up to sync with master first...

@JooHyukKim, @cowtowncoder Thanks for the quick reply. Details below. > Can you clarify the actual use case, beyond the implementation details provided? Actual use case: There is a modelling language...

I'm fine with reusing the same inheritance mechanism that Jackson uses under the hood. I think diverging from that behaviour would only cause confusion, where users expect the same logic...

> The problem with relying on that kind of undocumented (thus unguaranteed) behaviour is, users of your code may be in trouble if Jackson decides to change the behaviour/rule. I...

@cowtowncoder Thank you for the extensive context. What is your advice? Add an additional method to `AnnotatedMember` so users can access the `AnnotatedClass` reliably without using my current hack? Provide...