Simon Krajewski

Results 882 comments of Simon Krajewski

Does null-safety consider enums not-nullable? In that case we'll need a meta to explicitly mark enums as nullable.

Ah nice, it's good that it does that. But yes, a metadata specifically for enums makes sense to me. Enums are finite sets of values, and it would be good...

> Imo having null be a valid value under null-safety for a type that is not Null is weird and unexpected. I disagree specifically for enums. Enums can be understood...

> Imo that overloads the meaning of null too much. null is the null pointer, to me it doesn't make sense to give it a second meaning (for some enums)...

I have merged all of these PRs, let me know if you need anything else ufront-wise!

This is awesome, and I think it's a worthwhile endeavor. It's also quite neat that you can make a change like this with a relatively small PR. Looking forward to...

I just rediscovered https://github.com/HaxeFoundation/haxe/tree/development/tests/benchs while cleaning up. It's a generally useless micro-benchmark, but for something like this it's quite nice to see a direct comparison between different call kinds: ```...

Looks good! I suppose there would be an even bigger difference if it used integers instead of strings, because then we're in boxing land. Regarding native `final`, there's a headache-inducing...

I agree with that assessment and did the same on genjvm. Dynamic calls are comparatively slow there, but anon and class to anon are nicely optimized. Some of that is...

Nice! I like seeing these graphs, it's always good to visualize progress like that. I'd like to run this PR on https://benchs.haxe.org/ too, but it would be better if CI...