Simon Krajewski

icon location Germany

Results 882 comments of Simon Krajewski

Enum comparison checking depends on inexplicable conditions

This is #11536 with extra steps.

Atomic operations.

Could you resolve the conflict?

Atomic operations.

Thank you for your work and patience!

slow diagnose

I'm not sure what to do with this, and with all the changes to the caching recently there's a good chance that it has been addressed. If not, feel free...

haxe.Timer not working when called from a thread without event loop

Not sure, it mentioned event loops so I assigned you!

haxe.Timer not working when called from a thread without event loop

Fine for me, but let's at least update that notice on Timer, there's at least a typo there.

haxe.Timer not working when called from a thread without event loop

Never mind, typo was in my head.

Correct EnumValueMap implementation

I have updated the branch. It doesn't have https://github.com/HaxeFoundation/haxe/commit/7dc9272865afe5f4e1b5347da75c6d2700c67c99, which I would like to solve in a cross-platform way because I have the same issue on the JVM target. I...

Correct EnumValueMap implementation

I've added the HL optimization back so that we can merge this. An improved API is blocked on #11568 which may or may not take a while longer to address....

Correct EnumValueMap implementation

... I never really looked at the actual implementation here though. Building a map on top of arrays can be done, but linear cost for both read and write isn't...