Simen Bekkhus

Results 1232 comments of Simen Bekkhus

Thanks for the PR! Interesting feature, not sure where I stand on it. Wouldn't it be enough to do `global.Promise = require('promise/setimmediate');` in your own code? Then `runAllTicks` should work,...

@mjesun thanks! I take that comment to mean you're not against this landing in core then? Would be awesome if you could test it out in the FB test suite...

I don't think we should automatically compile away async-await. Rather, it should be implemented in `babel-jest` directly together with #6949 when we can inspect what plugins will be loaded for...

Also, I wonder what we should do when `async-await` becomes more normal on `node_modules`. It might be that we can't be clever and we just have to be really clear...

BTW, I think it definitely should be opt-in to transpile async-await, especially as we might be double-transpiling and potentially adding quite some overhead since we'll have to transpile `node_modules`. Debugging...

Sorta related: https://github.com/sinonjs/lolex/issues/114 (and #5171)

Ah, good catch! That's a bug in how we format `assert.throws` errors - we just assume the issue when it fails is no throw instead of inspecting. PR very much...

Broke tests for directories with parens... https://github.com/facebook/jest/blob/bc0f21d8145564364db5c12699224eb5c25c365e/packages/jest-cli/src/__tests__/SearchSource.test.js#L238-L256