Silvris

Results 17 comments of Silvris

Getting this same issue in FF5 and FF6 with the following patch. Very likely breaks in all 6 PRs. ```cs [HarmonyPatch(typeof(MasterBase),nameof(MasterBase.LineParse))] public sealed class MasterBase_LineParse { public static void Prefix(ref...

> LGTM! Does not hurt to support that, tho I'm not exactly sure what could be a usecase for an item being both progression and useful, for instance. 🤔 >...

Currently, I think just OoT and LttP actually use Direction. Realistically it can probably be added to Messenger/TUNIC should you ever want to support decoupled entrances, but MC and KDL3...

Something I've noticed while working on cleaning up my world with this, and will undoubtedly be a common question should anyone try to add their own world to this: ```py...

> With this current system, I can't do `self.options.plando_connections.remove(connection)`, nor can I do `self.options.plando_connections.exit = "Shop Portal"`, nor can I do `self.options.plando_connections[index] = replacement`, so as far as I can...

> is there a reason they don't just inherit from OptionList? it has the necessary overrides to do exactly as requested here This code would also fail on an OptionList,...

> I think the newline somehow got eaten? It's still there, Github hides it by default and instead shows a no symbol if the newline isn't present.

The unfilled locations are already accounted for within `.get_locations()`, we don't need to duplicate them. I wasn't actually sure that it used to be filled only, I just assumed that...