Silviu Marian

Results 15 comments of Silviu Marian

Hello there. I'm not sure what do you mean by that. What is it supposed to do and it's not doing?

Yes, I see what you mean. I'll add support for that in the next few days. Thanks.

Thanks for the effort. Don't worry about it, I'll have to add a button for it anyway. The only take is that I'm on vacation, so I can't really test...

Sorry for the long wait, I saw what you did there, looks like that's not the way to do it. Your implementation throws lots of `TypeError: Cannot read property 'constructor'...

Hello there. Thanks for giving time to this. I'm going to try a local test, not sure what steps to follow.

Ok so, I have the changes locally and need to test them. Can you please provide a simple test pattern? How should this feature work? There's a couple of bits...

Not a WeakMap issue, but it would be a bit tricky to add this We rely on `replaceReducer` from the supplied store instance to add new paths to that store,...

`numeral().format()` accepts a 2nd parameter which is the rounding function to use. In your case, you probably want Math.floor - `numeral(4986444.0).format('0.00a', Math.floor)` You can also use bitwise negation like this...

Rounding still has to occur. You can use `Math.floor`, `Math.rand` or `Math.ceil`, depending on the output you're looking for. Whay is your specific use case? :)

```js numeral.fn._format = numeral.fn.format; numeral.fn.format = function (a, b) { return numeral.fn._format.call(this, a, b || numeral._.defaultRoundingFunction); }; numeral._.defaultRoundingFunction = Math.round; numeral.setDefaultRoundingFunction = (fn) => { numeral._.defaultRoundingFunction = fn || numeral._.defaultRoundingFunction;...