Silvano Cirujano Cuesta

Results 162 comments of Silvano Cirujano Cuesta

Keeping it as `Draft` until issues on `main` are fixed and tests can succeed.

This PR will make more sense after merging this repo into `linkml` to have a monorepo.

@ialarmedalien do I understand it correctly? The conversations that you've opened in this PR are mostly justifying some of the changes, right? So a reviewer that holds those changes as...

@ialarmedalien I'm trying to run "ruff" myself just to be sure that I don't look at changes directly applied by the tool and I'm failing. I'm getting an error message....

@ialarmedalien I've realized that you are running `ruff` with different linters than those specified in the `pyproject.toml`. I could at least identify `isort`, and I've therefore [added it to my...

IMO the whole linting, ruff, tox,... set-up in both `linkml` (especially there) and `linkml-runtime` is a mess. I would seriously consider cleaning it up... If looking at `linkml`, we can...

@ialarmedalien > The main reason I didn't add my config into this PR is that I have pretty much all the linters enabled locally, which I would not necessarily suggest...

> @Silvanoc Apologies for unintentionally giving you a load of detective work to do in figuring out my ruff config! I would have included it as a comment on the...

Hmm, I'm not sure this PR was expected to get merged before #347. @ialarmedalien can you please confirm?

Please notice that I'm simply applying to [`_class_uri`](https://github.com/linkml/linkml/blob/ef12f48f2d900fa21b45ce815c85a0cc4b8c3cbc/linkml/generators/owlgen.py#L547) the same logic being used in [`_prop_uri`](https://github.com/linkml/linkml/blob/ef12f48f2d900fa21b45ce815c85a0cc4b8c3cbc/linkml/generators/owlgen.py#L556) that provides the expected result for slots.