linkml-runtime icon indicating copy to clipboard operation
linkml-runtime copied to clipboard

refactor: move modules from utils to types

Open Silvanoc opened this issue 6 months ago • 3 comments

Move modules defining types rather than utilities from linkml_runtime.utils to linkml_runtime.types.

Part of refactoring proposed in issue https://github.com/linkml/linkml/issues/2371

Important note: getting the changes that this PR tries to address effectively working requires a synchronized effort involving the repos linkml, linkml-runtime and linkml-model. Because the Python generator needs to be adapted so that generated classes take the new path and the model needs to be also generated with the new paths. It's questionable if the effort is worth the gain...

Silvanoc avatar May 20 '25 12:05 Silvanoc

Codecov Report

Attention: Patch coverage is 14.73684% with 162 lines in your changes missing coverage. Please review.

Project coverage is 63.40%. Comparing base (faac277) to head (259c3dc).

Files with missing lines Patch % Lines
linkml_runtime/utils/permissiblevalueimpl.py 0.00% 96 Missing :warning:
linkml_runtime/utils/curie_validator.py 0.00% 51 Missing :warning:
linkml_runtime/linkml_model/datasets.py 0.00% 5 Missing :warning:
linkml_runtime/linkml_model/validation.py 0.00% 5 Missing :warning:
linkml_runtime/linkml_model/mappings.py 0.00% 3 Missing :warning:
linkml_runtime/utils/schemaview.py 0.00% 1 Missing :warning:
linkml_runtime/utils/yamlutils.py 50.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   64.45%   63.40%   -1.06%     
==========================================
  Files          62       64       +2     
  Lines        8846     8993     +147     
  Branches     2556     2586      +30     
==========================================
  Hits         5702     5702              
- Misses       2535     2682     +147     
  Partials      609      609              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 20 '25 12:05 codecov[bot]

Keeping it as Draft until issues on main are fixed and tests can succeed.

Silvanoc avatar May 20 '25 12:05 Silvanoc

This PR will make more sense after merging this repo into linkml to have a monorepo.

Silvanoc avatar Oct 21 '25 18:10 Silvanoc