Siddharth Kumar
Siddharth Kumar
> @Siddharth-coder13 Somehow this PR #789 and PR #782 have become a mess and they both contain the same commits (e.g. `Defined a geometry for polyhedron` that is `0961662e6e45878eda378f85dd734ae1922f7110`). I...
> It's unfortunate. The 1 needs to be in the other separate PR and 2+3 as a separate feature in this PR. > > I understand this may make your...
Hey @mloskot, I think this PR is able to merge now.
> Hey @mloskot, I think this PR is able to merge now. or suggest changes if any.
Hey, @barendgehrels Thanks for your reviews, but I think this point needs a separate PR, because a single PR can not define everything about polyhedral surfaces. > 3. documentation including...
Hello @mloskot @barendgehrels @vissarion @awulkiew, as I have extended this PR as a project in GSOC'21 including other features of polyhedral surfaces. I want to get this PR merged before...
Hi @barendgehrels , thanks for the review. Actually, I added the example file of polyhedral surfaces, if unit test is needed in this PR, then I will add it asap.
Yeah, sure from next time I will make sure this.
Do this PR needs more changes? @mloskot
@awulkiew, your reviews are needed on this PR.