geometry icon indicating copy to clipboard operation
geometry copied to clipboard

Published 20 hours ago • verified publisher icon boostorg

Fixed Writing 3D WKT:Z prefix

Open Siddharth-coder13 opened this issue 4 years ago • 6 comments

Changed the wkt_point struct to take 3 parameters rather than 2, for one for 2d and one for 3d, added the prefix_z function in prefix.hpp, and also added a line of code to print 3d points in 01_point_example.cpp .

Siddharth-coder13 avatar Dec 09 '20 05:12 Siddharth-coder13

@awulkiew In https://github.com/boostorg/geometry/issues/664#issuecomment-583736980 you suggested

we'd need a separate function for that.

What did you have in mind?

This PR seems to follow my suggestion I made in https://github.com/boostorg/geometry/issues/664#issuecomment-583773745

@Siddharth-coder13 The commit and description of PR that addresses an existing issue should contain reference to the issue (i.e. #664)

mloskot avatar Dec 11 '20 15:12 mloskot

Yeah, sure from next time I will make sure this.

Siddharth-coder13 avatar Dec 11 '20 16:12 Siddharth-coder13

Do this PR needs more changes? @mloskot

Siddharth-coder13 avatar Dec 13 '20 09:12 Siddharth-coder13

@Siddharth-coder13 No, for now it does not, but we need to wait and clarify my question https://github.com/boostorg/geometry/pull/782#issuecomment-743275433 in order to confirm this is actually the kind of change we need and want.

mloskot avatar Dec 13 '20 09:12 mloskot

@awulkiew, your reviews are needed on this PR.

Siddharth-coder13 avatar Dec 29 '20 06:12 Siddharth-coder13

@Siddharth-coder13 Please, see https://github.com/boostorg/geometry/pull/789#issuecomment-777841388

mloskot avatar Feb 11 '21 22:02 mloskot