Sid Chang

Results 13 comments of Sid Chang

I have reviewed the code, and currently, only deal with the following types: ``` RegExp, Date, Map, Set, Array, URL, function, undefined, number, bigint ``` `Error` Object was not handled....

Hello, @okuryu @wujekbogdan I have added a patch about the support `Error` object. #136 PTAL, thx.

Is it related to this warning? `Warning: componentWillMount has been renamed, and is not recommended for use.`

> It should handle array too: https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1559#issuecomment-951072358 OK, thx. I will make up.

@sindresorhus Thank you for your review. I have made corrections and added Array checks, doc updates, and new tests. ~But I have the same problem as @kayac-chang~ ~It's about `CI...

This rule just reported the first duplicate index now. And I have tried to fix the CI fail.

> I don't think this rule should limited to Literals, > > ```js > const set = new Set([ > undefined, > undefined, > foo, > foo, > foo.bar, >...

Sorry, I didn't ignore this PR. It's just that I don't have a way forward.

I am looking at this issue.

I have added a rule about `Set` and `Map`. PTAL, thx.