Gaurav Shukla

@Chillee 'pytest test/test_ops.py::TestDecompositionOpInfoCPU -k batch_norm` is always passing for me locally. I do following steps to test: 1. pip install --pre torch torchvision-f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html --upgrade 2. python setup.py install 3....

@Chillee Apologies for the delay. I will rebase and push. Thanks!

@Chillee It looks like all the decompositions has been moved/removed?

> @Shukla-Gaurav Yes, can you re-open this PR on upstream PyTorch? Sure, will do that :)

I am encountering the same issue with this patch https://github.com/llvm/torch-mlir/pull/862 for ResNet18 static model. @sjarus `error: failed to legalize operation 'torch.constant.int'`

@cathyzhyi It seems right to keep the conversion pattern for the sake of completeness. But isn't it good to keep the folder also? It's like if something can be handled...

@ramiro050 Yes #862 will solve this issue. I tested it also. Thanks!

Once https://github.com/llvm/torch-mlir/pull/951 is merged, this PR will be unblocked wrt (3D, 2D) case of matmul.

@sjarus Could you please take a look into this, `ResNet18Static` is failing in torch to tosa lowering. Thanks!

@sjarus There is a case where `aten.matmul` fails to lower to tosa. I quickly looked into it but did not get the solution. Could you please look into it? `%3...