Sergey "Shnatsel" Davidoff comments

Results 942 comments of


                                            Sergey "Shnatsel" Davidoff

Use cargo-auditable with cross?

Unfortunately `cargo zigbuild` fails also, for an unrelated reason: #179 But at least that could be a reasonable feature request for Zig; I simply didn't get around to submitting it...

Add `Reader.read_row` for decoding into caller-provided buffer.

There doesn't seem to be any reason not to merge this. @anforowicz could you resolve the conflicts? I'll push the merge button as soon as that's done.

Unfiltering is slower on Windows than on Linux (especially with `std::simd`)

I've opened https://github.com/image-rs/image-png/pull/574 that drops the `std::simd` codepath for images with 4 bits per pixel. It's the only case where benchmarks on Linux on Zen 4 do not show any...

Re-encode example

This is fixed in master and shipped in v0.18.0-rc, so I'm going to go ahead and close this.

Provide multi-theaded PNG encoding option via mtpng crate

This was attempted in #478

Open questions about supporting Exif

I understand `reader.finish()` already discovers these chunks in v0.18?

Open questions about supporting Exif

Closing now that `png` v0.18 has shipped

Generics usage by decoders increase code size and compilation time

Now that we can make breaking changes, it's a good idea to revisit #2468 and make other changes before freezing the API again for a while.

Build fails with `cargo xwin` and a build script

Well, that looks like an intersection of `cargo xwin`, `cargo auditable` and Cargo's own caching. That's going to be fun to debug, I can already tell. Could you also post...

Github Release for cargo-auditable 0.6.7

Probably not. `cargo dist` actions failed because it's unmaintained, and running them on a release that's not the latest commit is very difficult. I could probably release 0.6.8 soon if...