Sergey "Shnatsel" Davidoff
Sergey "Shnatsel" Davidoff
I think I've addressed all the feedback so far (good calls btw!) and also added the implementation of #505 to this PR, as you requested.
As far as the configuration goes (ignoring streaming and such not touched by this PR) - yes, absolutely. The high-level compression options can transparently configure whether we're trying to palettize...
I resolved the merge conflicts that arose from the API-breaking changes in master. Now that we're doing breaking changes anyway, I'd appreciate getting this merged before the branches diverge once...
@anforowicz You can adjust your build system to enable optimizations for PNG crate even in debug mode. In Cargo you would add this to the `Cargo.toml`: ```toml [profile.dev] opt-level =...
FWIW `imagemagick` does provide this functionality, so a proper implementation of this could potentially be of use to `wondermagick`. But it is only an optimization, ideally and we'd have to...
To clarify, the async client doesn't provide a timeout for the entire request either, but I suspect it should be possible to hand-roll it in the async case.
Thanks for the quick response! The [`timeout`](https://docs.rs/reqwest/0.11.0/reqwest/blocking/struct.ClientBuilder.html#method.timeout) method on the blocking client builder is currently documented as follows: > Set a timeout for connect, read and write operations of a...
Ah I see. I've renamed the issue to reflect that it's merely an issue with the documentation. Is there a way to set the read timeout now? It can be...
I'm happy to try and apply this change unless somebody objects, since we have some semver-breaking API changes queued already.
This is implemented in git in #503, so I'm going to go ahead and close this as completed.