Sergey "Shnatsel" Davidoff

Results 943 comments of Sergey "Shnatsel" Davidoff

Symphonia v0.5 has now shipped with an extensively tested MP3 decoder (I've run over 500,000 MP3s through it alone, and compared the results to mpg123, libmad and ffmpeg). This seems...

Ah! I was under the impression that minimp3 was enabled by default, but it wasn't. This report is invalid then; but I'll open a new issue for switching to Symphonia...

Nevermind, I see you have updated to Symphonia v0.5 in git already.

The state of MP3 decoding in Symphonia is advertised as follows: > Most media streams play. Inaudible glitches may be present. Most common features are supported. I suppose the easiest...

Symphonia v0.5 has shipped just recently with a much improved MP3 decoder! I have personally tested it on over 500,000 MP3 files and compared the output to mpg123, ffmpeg and...

Here's a more egregious 14kb sample that takes 30 seconds and 5Gb of actually used memory to decode: [tiny-5gb-30sec-input.ogg.zip](https://github.com/RustAudio/lewton/files/2923052/tiny-5gb-30sec-input.ogg.zip) It should be possible to synthesize files causing even more dramatic...

Patching Lewton might no longer be necessary, since Symphonia now has a Vorbis decoder. It's 100% safe code and is at around 10% slower than ffmpeg. Correctness should be quite...

Any updates on this? The linked Phabricator ticket lists that the VPS instance has been provisioned, but no further updates are provided.

Oh, I have a whole bunch of OOM-crashing samples from fuzzer. Here you go: [oom-samples.zip](https://github.com/RustAudio/lewton/files/2907388/oom-samples.zip)

> I think that a good way to fix this issue is to have the ability to set custom, failible allocators. Then I could just set any limit I want....