Shivan comments

Results 105 comments of


                                            Shivan

[Request-OTR] Mode can't be turned off if `Go Off-The-Record when visiting sensitive sites` is set to Always.

This seems to happen for non-request-otr.json websites.

OTR tabs should not be included in session restore

This whole feature has been de-prioritized: it's now a "nice to do at some point". I'll mark this as a P4.

Issues with Media Queries / Breakpoints for responsive design on MacOS

@machancock could you put together a test/demo website for this? That would help a lot with debugging. Else I will get to it in a while.

[OTR] Some data like Favicons, are not removed after closing OTR tabs.

I wonder if this is fixed now with more/better partititioning.

[OTR] OTR website shows up in URL autocomplete list when the website uses `Request-OTR: 1` header

I was able to repro this with https://request-otr-demo.netlify.app/ https://github.com/brave/brave-browser/assets/5284154/72005060-2df4-4ac8-948c-07e141f7e589

Separate Site and Shield Settings from History in Clear Private Data

Great! Just a reminder that this is an iOS issue. You will need to follow https://github.com/brave/brave-browser/wiki/iOS-Development-Environment to get set up. Please let us know when you have a PR that...

OTR tabs should not persist site engagement or media engagement scores

We should follow Chromium's approach for Incognito tabs here: > When in incognito mode, site engagement will be copied from the original profile and then allowed to decay and grow...

[OTR] Existing History entries get renamed to `Sensitive Website` because of the Interstitial page.

I edited the issue description to be clear what the actual problem and solution is here.

Error in console on any site - with shields enabled

> > Can you visit `brave://components`, update `Brave Ad Block Updater` to version `1.0.7178` or later, and let me know if that fixed it? > > Yes! That's did it...

Brave shield breaks OpenAI

Where do you see ERR_BLOCKED_BY_CLIENT? In the console? Can you take a screen recording?