brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

Separate Site and Shield Settings from History in Clear Private Data

Open StephenHeaps opened this issue 5 months ago • 4 comments

On iOS in Settings > Shields & Privacy under Clear Private Data if you have Browsing History selected we will remove/reset Site and Shield Settings (Site-specific shields preferences, zoom level, and wallet dApp permissions). We should separate these to align with desktop, adding a new Site and Shield Settings toggle. It will default off to align with desktop, but similar to the other toggles, once it's toggled on it will remain on after user has tapped Clear Data Now.

Steps to Reproduce

  1. Connect to an ethereum dApp, ex. https://app.uniswap.org/
  2. Change the zoom level
  3. In the Shields panel, change some shield preferences
  4. Visit Settings > Shields & Privacy, under Clear Private Data disable all toggles except Browsing History
  5. Tap Clear Data Now
  6. Visit the dApp site again and notice the dApp connection is removed, zoom level is reset, and Shield panel preferences are reset to defaults / global preferences.

Additional Info

Site and Shield Settings was originally included here: https://github.com/brave/brave-ios/issues/5134

StephenHeaps avatar Nov 11 '25 20:11 StephenHeaps

HEy @ShivanKaul i want to work on this issue

AdminAdi avatar Nov 12 '25 17:11 AdminAdi

Great! Just a reminder that this is an iOS issue. You will need to follow https://github.com/brave/brave-browser/wiki/iOS-Development-Environment to get set up. Please let us know when you have a PR that we can take a look at.

ShivanKaul avatar Nov 12 '25 17:11 ShivanKaul

Okk sure

AdminAdi avatar Nov 12 '25 17:11 AdminAdi

@AdminAdi have you began working on this issue? If so what's your status?

EliHini avatar Dec 09 '25 18:12 EliHini