Sheppsu

Results 18 comments of Sheppsu

I'll work on redoing the current example file with the critique I've gotten from everyone.

Is it preferable that the example be structured similarly to the basic_voice.py example or instead use a slash command implementation? Could also simply scrap the example all together if it's...

> When I look at the code, I don't understand how it can be implemented. In fact, the callback contained in after, called by the listen function, only gets 2...

> The callback doesn't need to receive that information that way- you could for example, use a sink factory that took that information in from the scope. Could you expand...

Those problems were caused by a bad oversight from me where `read` was called on a closed file.

> It is not totally fixed, indeed `file.file.read()` also blocks^^. I find this strange because the file attribute in this case should be None after `convert` finishes running. > Also...

I believe it's not blocking the code, but actually an exception is occurring and it's not being shown in the console due to the error handling, which calls _log.exception (is...

> Wouldn't it be better to use `discord.Object`? I assume you mean replacing `int` with `discord.Object`? That works well for the use of `discord.Object` so I'll consider implementing that.

> There is also a very common silent error, sometimes the converter does not find the file to convert. Do you have any steps for reproducing this? I've never come...

Should be fixed, just put something like this inside the loop: ```Python while voice_client.is_listening() or voice_client.is_listen_cleaning(): await asyncio.sleep(0.1) ```