Yike Xiao comments

Results 24 comments of


                                            Yike Xiao

fix: add id field to bookie socket address struct

It respects the latest bookkeeper rest api, looks good to me.

Autosave

At least give a prompt before close window if made changes.

[improve][client] Throw more meaningful derived exception instead of PulsarClientException

> Looks good. We should probably also have assertions in the tests to ensure these proper exception are thrown, so that we don't have regression cases. Ok, I'll add unit...

[improve][client] Throw more meaningful derived exception instead of PulsarClientException

> Looks good. We should probably also have assertions in the tests to ensure these proper exception are thrown, so that we don't have regression cases. @merlimat Unit test added,...

[improve][client] Throw more meaningful derived exception instead of PulsarClientException

/pulsarbot rerun-failure-checks

[improve][client] Throw more meaningful derived exception instead of PulsarClientException

/pulsarbot rerun-failure-checks

[improve][client] Throw more meaningful derived exception instead of PulsarClientException

/pulsarbot rerun-failure-checks

[improve][client] Throw more meaningful derived exception instead of PulsarClientException

@lhotari @codelipenghui PTAL

[improve][client] Throw more meaningful derived exception instead of PulsarClientException

/pulsarbot rerun-failure-checks

[improve][client] Throw more meaningful derived exception instead of PulsarClientException

@codelipenghui Please help review this PR, thanks.