Sharath MK

Results 99 comments of Sharath MK

Hi @zamog @william-wang Any update on this PR?

+1 for this feature. Currently this package works amazing for my use case.

@cheina97 @aleoli Can I get review please? Thanks

> Hi @Sharathmk99! Can you explain your changes and why they are needed? Hi @aleoli, In version 0.8.x Resource plugin was providing `aggregated node resources - pod usage resources` but...

@alberttorosyan @mihran113 would appreciate review comments on this PR. This PR changes only import orders, double quotes, simple limiting rules.

@mihran113 Can I get review of the PR? Please let me know if I need to change anything. Thanks

Hi All, Is it possible to review the PR? I’m open to make changes if required. Please let us know if this PR makes sense. Thanks.

> Hi @Sharathmk99! Sorry for late response; we are still in the process of deciding on the linting and formatting, but will most probably end up using combination of `black`...

@SGevorg @alberttorosyan As agreed I have reopened the PR and configured to use single quotes. Please do review and let me know if any questions. Thanks

> @Sharathmk99, sorry for late response; took some time to go through the changes. > Everything looks good, seems there are some minor fixes left (the workflow fails on the...