liqo-resource-plugins icon indicating copy to clipboard operation
liqo-resource-plugins copied to clipboard
verified publisher icon liqotech

Fix Node Selector Resource Plugin

Open Sharathmk99 opened this issue 1 year ago • 4 comments

With latest version of Liqo, we don't need to subtract pod resources from node resources. This PR will fix this.

Sharathmk99 avatar Feb 12 '24 14:02 Sharathmk99

@cheina97 @aleoli Can I get review please? Thanks

Sharathmk99 avatar Feb 12 '24 15:02 Sharathmk99

Hi @Sharathmk99! Can you explain your changes and why they are needed?

aleoli avatar Feb 13 '24 15:02 aleoli

Hi @Sharathmk99! Can you explain your changes and why they are needed?

Hi @aleoli,

In version 0.8.x Resource plugin was providing aggregated node resources - pod usage resources but this logic doesn't work with latest version of liqo.

With liqo version 0.10.x resource plugin should just provide aggregated node resources without subtracting pod usage resources.

This PR will remove pod resources calculation and provide only aggregated node resources only.

Sharathmk99 avatar Feb 13 '24 21:02 Sharathmk99

Hi @Sharathmk99, can you please squash your commits before merging? Thanks

aleoli avatar Feb 20 '24 10:02 aleoli