Shaopeng (Chris) Lin
Shaopeng (Chris) Lin
@kelson42 Do we want the preview button to persist after the download? If so: To confirm, what are the book URL rules on https://library.kiwix.org/? The download URL is no longer...
On it right now. Had courses during the day. Should be ready soon (also moving to a feature branch as you mentioned).
@kelson42 I will add javascript disabling in a separate PR.
@kelson42 I am unable to find any primitives. The getBooksCategories already get from libkiwix and they are all still using the i18n key string we have. The only thing I...
With the slugify PR I think I am comfortable with the libkiwix structure. Can probably have a PR on libkiwix to add the i18n translation for categories and expose the...
That makes sense, I will adapt the filtering with the translations. @kelson42 Just to make sure I do not make any more misconceptions: From the previous discussion, I assume all...
Ok so I believe we actually are implementing two separate things: 1. retrieve categories from libkiwix. 2. The translation should use libkiwix translation functions. Previously I got the idea that...
Also in desktop we also don't seem to be doing translations either... I already have the change ready and after libkiwix goes through my change in this one will soon.
I am a little against using it in test/archive. The `CapturedStderr` Class is using rdbuf to read the stream buffer which our class is intended to hide. It makes the...
Also, I think we should place the class in include/zim/tools.h. After installation, error.h would not be able to use this class.