Shaopeng (Chris) Lin
Shaopeng (Chris) Lin
#140 will be a useful feature. Some feature additions on the new empty tab could make it very useful. Though before it is implemented, it does not really serve a...
Sorry I am not sure what is meant by "not finish to be implemented"? Could you point me to the ticket (did you mean #499 )? Just to clarify I...
I think blocking external fetches is the way to go. We can just block requests that do not "zim://". For the CSP injection, I can see blockers on my side...
This PR should resolve the weird behavior. The #436 was not using shortcut focus events correctly and we got a different behavior. It was also a duplication of the existing...
@kelson42 The bug is that using shortcuts to search doesn't work: 1. Use either of the 3 shortcuts to navigate to the search bar 2. search anything 3. type enter...
Not familiar with the qqq.json syntaxes. I am wondering if simply adding context for `"searcher-placeholder"` is enough for the translations. The prefix just needs a direct translation I believe. If...
Will do rebase after review.
@veloman-yunkan I found two ways for type checking for both Qt5 and 6: - `r.typeName() == QMetaType(QMetaType::QByteArray).name()` - - `r.userType() == QMetaType::QByteArray` :x: The typeName approach isn't something we want...
> @ShaopengLin Sounds straight forward to me. Would you be able to provide a mockup of a „preview“ button? What type of behaviour do we want? - Open the link...
I have some potential mockups 1. This is pretty straightforward and keeps the same feel of the UI. One problem is, that once the download starts, users cannot preview the...