Shane M Putnam
Shane M Putnam
The polygons associated with the NOAA Atlas 14 volume and region do not perfectly overlap with the volume codes and their associated precipitation frequency rasters. For example, volume 8, region...
Add a scope/summary of the hydromet_stratified.py below the libraries and above the functions. This way the user can get an overview of the contents and understand the workflow before diving...
All local variables and functions should be lower case and for readability, all functions should have a description even if they seem self-explanatory.
For method-specific variables like S_Limit, include a short description and an example value or range of acceptable values in the docstring. Similarly, when passing an array of parameters to a...
In plot_runoff_distributions_final, the discharge range is hardcoded, ideally, you want this to be flexible for plotting in different areas, same in plot_max_potential_retentin_cond_runoff. Try to avoid hard coding when possible, can...
USACE recommends using confidence limits between 0.01 and 0.99 for calculating the mean curve. Consider reducing the range of confidence limits.
When fitting the GEV to the NOAA Atlas 14 precipitation data and to the flow frequency curve in hydromet_stratified.py, for the bounds, could the loc/mu be greater than the average...
It is good practice to add asserts/warningsto the code to make it more robust. For example, a warning could be added if the users enters a PMP that is unreasonably...
Read the docs needs to be updated to include documentation from PR #37 on the fluvial analysis.