Shane Krueger

Results 854 comments of Shane Krueger

No I don’t think so. It was added in #2283 and deprecated a year later in #2879 and has been deprecated for a year and a half. It is probably...

And it should be pretty uncommon for type-first code. Like I’m sure I use OutputType a few times in my code, but that would be it. Not worth an analyzer.

That sounds great!

Just FYI, here's a few comments that may be helpful: When `InputObjectGraphType` is in use, `ObjectExtensions.ToObject` is called from `InputObjectGraphType.ParseDictionary` (unless overridden). When `GetArgument` is later called, the object isn't...

I don't really have any other goals for 7.7. So whenever you finish the analyzers or anything else that you think should be included in 7.7, lmk and we can...

Another analyzer idea: prevent invalid uses of `IGraphType`-derived classes, such as: (I did this today) ```cs //valid GraphQLClrInputTypeReference //invalid GraphQLClrInputTypeReference ``` Ditto for `GraphQLClrOutputTypeReference` and `IDataLoaderResult`. Unfortunately there's no type...

Well, v7 does not allow internal properties, and for reference System.Text.Json does not normally deserialize to internal properties (see [here](https://github.com/dotnet/runtime/issues/31511#issuecomment-1788790308)). v7 did allow internal/private constructors, but I don't think it...

Why wouldn’t your prior sample work for init properties ?

Maybe that’s okay. Is the source generator opt in or always on by default?

Perhaps we should start by simplifying the reflection-based design for v8, then making the source-generated version of it. I could probably do the former part, and we could discuss. Then...