Michael Bryant comments

Results 37 comments of


                                            Michael Bryant

Compilation failures on Linux for Rust 1.72.0 - 1.80.0

Thanks for the report! MSRV on `main` is currently `1.70.0`, as I have not updated anything in a while. #203 will update dependencies to latest, remove lints that no longer...

Compilation failures on Linux for Rust 1.72.0 - 1.80.0

This should be fixed with 0.6.1

Applicaton - Checking License - Not Valid

@AreYouLoco Let's not suggest people circumvent license verification, even if they purchased a license.

Fix enum types spec generation

Commenting to note that (1) this is something that still needs fixing and (2) this PR seems to still apply cleanly to current `master`

service: Fix order of arguments in FreeBSD

> we need to define what scenarios we're trying to support here If I can add input as the issue author... The original issue is that the `service` module does...

feat!: change `InstructionHandler` to be a trait and require it everywhere in Rust

> This has the potential to provide signficant performance improvements (and I think it's probably cleaner regardless). Have you verified any potential improvements with benchmarks?

Env variables leak into other tasks

This is intentional: https://sagiegurari.github.io/cargo-make/#task > Note: Reordering of task variables with global variables will not take place. Tasks simply overwrite previously declared variables. > > Note: Variables are not cleaned...