Michael Bryant

Results 37 comments of Michael Bryant

Just ran into this on some projects. The action fell back to using `cargo install` and suggested I use `--force` to make overwrite the previous installation (that was cached from...

For more context, [this](https://github.com/rigetti/quil-rs/blob/f717bc1d8105c8f28ab781823e0f7d80138eac93/quil-rs/src/expression/mod.rs#L465) appears to be the only function that uses `lexical`, so it should be fairly straightforward to replace

> > First, make sure you run cargo clippy --all-features -- there are some things like format!("{}", value) that would be caught by it. > > That's strange, doesn't look...

> We're probably going to have a problem when we get to 0.15.0, since there is already a 0.15.0-rc.0 [on crates.io](https://crates.io/crates/quil-rs/versions). Do you think we should just tag 0.15.1 and...

Updated the `knope` version to 0.7.0 and fixed some `clippy` lints so that CI passes.

This PR is so old, better to start over

See also: discussion at https://bheisler.github.io/criterion.rs/book/faq.html#how-should-i-run-criterionrs-benchmarks-in-a-ci-pipeline

- [x] Parser wrapper `token_with_location` calculates line and column number before running the wrapped parser, but should do it after success. (included with #113) - [ ] `lex_number` and `lex_punctuation`...

Probably the biggest item at this point is actually the fact that line and column information are gathered for tokens during lexing, in case an error occurs when parsing the...

Conventionally, errors implement `std::fmt::Display` (which has a blanket impl for `ToString`), not `From for String`. For this, most likely we'd want to use `#[derive(thiserror::Error)]`.