Grigorii K. Shartsev

Results 583 comments of Grigorii K. Shartsev

@kra-mo we don't do it manually for every language. We are using the native Intl formatter. The problem is that the default formatter doesn't shorten thousands in German and Italian...

> Maybe ask upstream? Upstream is Google, Microsoft, Apple and Mozilla with their browsers, so, I'm unsure if it is an option :) The question is: do we want to...

> (and in English as well?) it would have to be a lowercase "k", so "2k" @jancborchardt It uses native browsers formatter, not a custom one. So in English it...

Note: counter in EN and DE on YouTube. Indeed, it is not shortened with K, as @szaimen noticed.

> What we could also do is then simply not shorten the thousands if we think it’s fine. What happens above certain limits like with 10k, 100k etc? At what...

> What we could also do is then simply not shorten the thousands if we think it’s fine. That is the current state

In `v8` there was `exact` prop because `NcAppNavigationItem` is a wrapper over `RouterLink` which had the `exact` prop in the past in Vue 2. In other words, removed `NcAppNavigationItem`'s `exact`...

The created PR also doesn't bring back the `exact` prop but acts like (also removed in vue router) `exact-path` prop, which could be even more confusing.

However, having all the links active inclusive is a problem indeed. To avoid it, we can: 1. Always use `isExactActive` instead if `isActive` 2. Allow to use `active` prop to...

> But why not use the information that is already available in the component instead of having the parent component determine whether the route is correct or not to set...