Seweryn-Zielas-Mobica
Seweryn-Zielas-Mobica
@SaschaWillems > I'm not sure if we want to merge this in it's current state. The changes to the framework allowing to toggle between GLSL and SPIR-V are fine, but...
I have tested every sample to ensure everything runs correctly - used "batch" command on Ubuntu 22.04.3 LTS. Didn't spot any new compiler warnings, validation errors/warnings or any other regression.
@gary-sweet About testing this plugin, I think easiest/quickest way would be to use patch that I attached to this comment, It is basically revert of commits that removed plugin support...
@gary-sweet I created temporary PR like you requested - https://github.com/KhronosGroup/Vulkan-Samples/pull/953 Also there is one fail and canceled checks here that looks like infrastructure issue, is there a way to make...
@marty-johnson59 I've fixed merge conflict, it was a small one in ".copyrightignore" file.
I changed way of using dxc for offline compilation. I had problem with **add_custom_target/add_custom_command** that created targets in top level view of Visual Studio solution, I was only found way...
@SaschaWillems As we discussed that we should only add offline compilation for HLSL, I've created created new PR that only do this, as it seemed easier and less misguiding when...