SettingDust

Results 138 comments of SettingDust

Haven't noticed it's private. Make it public now

What's the workaround for this? EDIT: https://github.com/Kotlin/kotlinx-datetime/blob/master/core/common/src/serializers/DateTimeUnitSerializers.kt#L199

My workaround based on @christofvanhove 's method ```kotlin @Serializable data class PolymorphicSurrogate(val value: T) inline fun PolymorphicPrimitiveSerializer() = PolymorphicPrimitiveSerializer(serializer()) inline fun SerializersModule.PolymorphicPrimitiveSerializer() = PolymorphicPrimitiveSerializer(serializer()) class PolymorphicPrimitiveSerializer(private val serializer: KSerializer) :...

> I believe it would work fine if the `linkedom` was less buggy. maybe you can try to use happydom for testing

> People generally recommend using `jsdom` with `readability`. FYI It's too heavy. We used to use it. The Happy DOM slogan is JSDOM alternative > [Happy DOM](https://github.com/capricorn86/happy-dom) focuses heavily on...

After some tests. Happy DOM doesn't support many pseudo classes like `:not`, `:is` make it isn't an option for now. I'll look into the linkedom and readability for this issue

Like https://github.com/mozilla/readability/issues/836#issuecomment-1911720374 said. The pinterest returned html is wrong ![图片](https://github.com/extractus/article-extractor/assets/19922286/b5312c76-6001-49a9-a785-d89fd0675352) Readability won't work as expected I think. I'm going to try catch the content parser and don't include content property...

> Anw, if the HTML structrure is not well-formed, no library can help. And yes, I think we should catch the error like this. Browser, JSDOM, or happy dom will...

> Or can I pass my DOM object instead of the HTML as a string? That's a point I mentioned before. I'm going to do that in new extractus project.

> I am not after special kind of content. I'm after very random pages on the internet. :) It fails not only on the pinterest, but a large amount of...