Nikita Zheleztsov
Nikita Zheleztsov
> Will not it more logical to 'mask interruptions' Do you propose to export to public the ability to set the fiber 'cancellable'? If so, what can prevent the user...
Consider this review iteration as a draft one. We should at least discuss, if we need some public Lua API for user to know that the fiber is system. Tomorrow...
They're a number of fibers, which can be marked as system ones: * [relay](https://github.com/tarantool/tarantool/blob/969b76ac9901840156c6b9fad45d70ab5de6f221/src/box/relay.cc#L880); * [hot_standby](https://github.com/tarantool/tarantool/blob/969b76ac9901840156c6b9fad45d70ab5de6f221/src/box/recovery.cc#L531); * [vinyl_task](https://github.com/tarantool/tarantool/blob/969b76ac9901840156c6b9fad45d70ab5de6f221/src/box/vy_scheduler.c#L438-L439); * [box.watcher](https://github.com/tarantool/tarantool/blob/969b76ac9901840156c6b9fad45d70ab5de6f221/src/box/watcher.c#L299-L300); * [trigger](https://github.com/tarantool/tarantool/blob/969b76ac9901840156c6b9fad45d70ab5de6f221/src/lib/core/trigger.cc#L116); All of them are not mentioned in cartridge's...
> And grep all the other `fiber_new()` calls in our C code to check every place in case anything else is missed. Yep, that's definitely the thing I do. Here's...
> Seems fine to cancel it. It will terminate the process most likely, but gracefully. You're right, it's terminated gracefully. Added swim and on-shutdown, deleted interactive
Rebased, fixed commit message and added changelog.
Actually, in previous versions (e.g. in tarantool 2.6) the state of connection after explicit fiber kill is `error`: Tarantool 2.6 ``` tarantool> _TARANTOOL --- - 2.6.0-0-g47aa4e01e ... tarantool> c ---...
I agree with Vlad's opinion. `wait_connected = false` must work the same way `is_async = true` option behaves now. Currently due to that bug, async requests in vshard may yield...
Placing `export HSA_OVERRIDE_GFX_VERSION=11.0.0` right after venv activation in `invoke.sh` fixed the issue with AMD Radeon RX 7800 XT. Here's the source: https://github.com/invoke-ai/InvokeAI/issues/4211#issuecomment-1886423884
Closing as resolved in https://github.com/hyprwm/hyprland-plugins/issues/175#issuecomment-2183225324