Alex
Alex
Since we know all of the tag types ahead of time, there's no reason we couldn't preserve the format-specific items (or the entire tag itself) in an immutable way inside...
The repo has always had multiple crates, there's really no reason not to convert to a workspace. This would also be really nice when combined with #311.
The new [lints section](https://doc.rust-lang.org/stable/cargo/reference/manifest.html#the-lints-section) in 1.74 makes it possible to move all the lints out of lib.rs: https://github.com/Serial-ATA/lofty-rs/blob/c606e07c62cb74ff3a15bb1eef4aec3c33e2d145/src/lib.rs#L101-L148
- [x] Audio property reading - [x] Tag parsing - [x] Tag encoding - [x] Writing tags to files ~~Everything's in place now. Just need to actually write the tag...
This adds two new traits, `Truncate` and `Length`, which are two operations we needed that required the use of `File`. With these two traits, combined with `std::io::Read`, `std::io::Write` and `std::io::Seek`,...
Similar to `Picture`, once chapters are supported in ID3v2 (#189), EBML, Vorbis Comments, and MP4, it may be worth creating a generic representation of chapters that can be converted to...
The major brand is kept in `Mp4File` for some reason. https://github.com/Serial-ATA/lofty-rs/blob/main/src/mp4/mod.rs#L34-L35 The field, along with its getter, should be moved to `Mp4Properties`.
## Native frames - [ ] [AENC](https://mutagen-specs.readthedocs.io/en/latest/id3/id3v2.4.0-frames.html#aenc) Audio encryption - [X] [APIC](https://mutagen-specs.readthedocs.io/en/latest/id3/id3v2.4.0-frames.html#apic) Attached picture - [ ] [ASPI](https://mutagen-specs.readthedocs.io/en/latest/id3/id3v2.4.0-frames.html#aspi) Audio seek point index - [X] [COMM](https://mutagen-specs.readthedocs.io/en/latest/id3/id3v2.4.0-frames.html#comm) Comments - [ ] [COMR](https://mutagen-specs.readthedocs.io/en/latest/id3/id3v2.4.0-frames.html#comr)...
It's a common issue that padding will often stick around between tag edits, as it is typically not properly accounted for in the tag header size. We currently just get...
### Summary We could parse timestamps in the following frames: TDEN, TDOR, TDRC, TDRL, TDTG. Instead of `FrameValue::Text`, they would now use `FrameValue::Timestamp`. The structure is described in the [ID3v2.4...