SergeyKorytnik

Options::Options() constructor is defined without a matching destructor

1

At https://github.com/google/draco/blob/c0b57c1b6ec365a5e97f765deacb6b45ead104a3/src/draco/core/options.cc#L23 You can see the Options::Options() constructor is instantiated. As soon as constructor is here it would be great to instantiate the destructor as well. Just add ```cpp Options::~Options();...

The following if statements should be if constexpr in C++17 and above: https://github.com/google/draco/blob/b43b42c744f550f2a739c0ce7207e1fc078a7e3b/src/draco/attributes/geometry_attribute.h#L366 https://github.com/google/draco/blob/b43b42c744f550f2a739c0ce7207e1fc078a7e3b/src/draco/attributes/geometry_attribute.h#L369 https://github.com/google/draco/blob/b43b42c744f550f2a739c0ce7207e1fc078a7e3b/src/draco/attributes/geometry_attribute.h#L378 https://github.com/google/draco/blob/b43b42c744f550f2a739c0ce7207e1fc078a7e3b/src/draco/attributes/geometry_attribute.h#L381 https://github.com/google/draco/blob/b43b42c744f550f2a739c0ce7207e1fc078a7e3b/src/draco/attributes/geometry_attribute.h#L386 and not as trivial but constexpr parts from the following if statements should...