Serendo
Serendo
> 追加路径的方式设置remote_ext_dic,就很尴尬。既然是remote词库,有可能我需要某个索引的remote_ext_dic是路径完全不同的地址。例如:IIKAnalyzer设置是本地文件路径,而我某个索引希望设置一个 remote-api地址。。。或者说,我集群未设置remote_ext_dic,某个索引希望通过设置custom_dict_name的方式使用remote_ext_dic,都无法做到。 我是用一个nginx做的分词服务器,如果子路径的文件不存在,就直接返回默认的词库(就是父路径那个地址),这样词典服务器很好维护:有用户有自定义词典需求时,创建一个文件夹,放入词典文件就行。对于外部的remote-api地址,通过nginx转发过去应该也可以实现,只不过remote-api的地址信息就不是配置在索引setting里了。
I tried to comment out controllerutil.SetControllerReference in pkg/controller/chap/chpa_controller.go and it no longer set owner reference to deployment any more. I'm testing to see if there is any side effects.
> @Serendo any update on this ? It's safe to do this. Deployments will no longer be deleted.
I find that the problem is with this api that arduino-cli uses, it gives the wrong result. ``` curl -s https://builder.arduino.cc/v3/boards/byVidPid/0x303A/0x0002 ``` ``` {"architecture":"esp32","fqbn":"esp32:esp32:deneyapmini","href":"/v3/boards/esp32:esp32:deneyapmini","id":"deneyapmini","menus":[{"id":"UploadSpeed","name":"Upload Speed","variants":[{"id":"921600","name":"921600"},{"id":"115200","name":"115200"},{"id":"230400","name":"230400"},{"id":"460800","name":"460800"}]},{"id":"CDCOnBoot","name":"USB CDC On Boot","variants":[{"id":"default","name":"Enabled"},{"id":"cdc","name":"Disabled"}]},{"id":"MSCOnBoot","name":"USB Firmware MSC...
It's not using just boards.txt which is esp32 side. but also this web api (https://builder.arduino.cc/v3/boards/byVidPid/0x303A/0x0002 ) which i believe is provided by arduino and it's discovery machanism. This deneyapmini pid...
Maybe loki should implement a disk watermark and stop receiving logs when the disk is nearly full to prevent a corruption?
> Hi @Serendo, thank you for this PR! I think this is not a breaking change (from the perspective of Vector users). And also we will need a changelog to...
> Hi @Serendo, are you still working on this? I see you asked for a review last week but there are still outstanding review comments to be addressed. It would...
> > And yes it will be great to get some help from you. Thank you! As you see when modifying the original request, there is a metadata part which...
Hi @pront , can you do another review?