sapenlei comments

Results 12 comments of


                                            sapenlei

Allow public path to be a function

@alexander-akait I would like to create a PR. But I have two solutions for this. I can't decide which is better. 1. add a new option called dynamicPublicPath. * Pros...

Socket.IO Adapter Close causes premature HTTP Server close() call and blocks application shutdown

> Would you like to create a PR for this issue? We should only do that for adapters that don't share the HTTP server instance (so for those that use...

fix(core): Improve middleware route exclusion for dynamic endpoints

> Could you also add an integration test? Yes, I can

fix(core): Improve middleware route exclusion for dynamic endpoints

Integration tests have been completed @kamilmysliwiec

fix(core): Improve middleware route exclusion for dynamic endpoints

@kamilmysliwiec Can this be merged? 😭

fix(core): Improve middleware route exclusion for dynamic endpoints

> We need to be very careful when making any changes to the middleware exclusion algorithm as they will certainly affect many users of the framework. Might need to wait...

feat: Improve access to resolver data in module.rules and rule.use

> Can you add a test cases? yes, I can

feat: Improve access to resolver data in module.rules and rule.use

![CleanShot 2024-12-12 at 14 25 21@2x](https://github.com/user-attachments/assets/3da26c9d-7a93-4572-b480-3069e2b04d00) What does this mean? I can't see where the error is. @alexander-akait

feat: Improve access to resolver data in module.rules and rule.use

@alexander-akait

fix(plugin-legacy): avoid emitting the asset when renderLegacyChunks …

@sapphi-red