Christopher Knight

Results 24 comments of Christopher Knight

Note to also add `AuthEventId` and the logic of updateTenants to readme > https://github.com/XeroAPI/xero-node/issues/475

Hi Andrew. So to get to the crux of this are you saying `createInvoiceAttachmentByFileName` is not working as expected? https://xeroapi.github.io/xero-node/accounting/index.html#api-Accounting-createInvoiceAttachmentByFileName Or are you trying to use the `getInvoiceAsPdf` but the...

Hey @samueldjones24 - agreed this would be ideal to auto-detect. We've got full examples in the sample app but you make a good point. Added examples for both getting files...

> Agree with the latter :) great to have the option to add headers as well, but it is also missing from the documentation, that'd help to imagine the workaround...

Hi Adam - sorry on the delay here. I've been toying around with throwing a more distinct error object. We've also got a project in the works that's aim is...

Thanks Adam - this is really helpful and gives me a much clearer idea on how to potentially provide you a solution without a breaking change. Will put some work...

Another example is that the descriptions of the UK payroll enums were never represented in the spec. Once we surface descriptions clearly in the new docs, this solve should be...

I'm a bit unclear on this as is. I know Xero's endpoints sometime swap the functionality for PUT and POST as to what would be expected. Just based on docs...

We are working on this migration now. Will try to get it back into project sometime in the new year.

Hi @mattholwood - I agree. The current size is not reasonable. We've had some team churn around support for this so larger refactors like these have been put on hold....