Andrew Millington

Results 186 comments of Andrew Millington

PRs are always welcome so please feel free to have a stab at this. According to the spec (and I am saying this from memory rather than checking it), I...

Reopening this as want to eventually implement Alex's solution of not passing refresh token repository to grants.

I think this implementation could be simplified. Ideally what I'd like to see in the package is a language file which will hold all of the various error messages and...

Will address issues raised in issue #1093

- [ ] Convert exception class to final - [ ] Remove previous reference in changelog of hint fix for invalid credentials on the password grant

Under the current implementation, we can't support public clients for the password grant or refresh token because we always check client credentials. We need to add a same is confidential...

@stratoss sorry for not picking this up earlier. I think this issue got lost when switching maintainers and I somehow haven't seen it until now. Could you please explain why...

Thanks @sg3s. Yeah, I'm sure we need to keep this in, I'm just not sure we should be allowing people to choose different characters from a # as the pull...

Hi @nicolassing - I haven't yet but @alexbilbie had started on something so I'd planned on using that as a start at some point. I can't say when though as...