Andrew Millington

Results 186 comments of Andrew Millington

Hi @robbytaylor. I'm not sure about the change to the `generateHttpResponse` interface as you have pointed out in our comment. I also note that this is currently failing our PHPStan...

@michaeldnelson the last link you posted is for a draft version that has not been finalised yet I believe. I think you might be right that the `aud` should be...

I don't think `fileperms()` is reliable on Windows and is only really viable on Unix systems. This is one of the reasons we only issue a notice. I must admit...

Reopening this issue. I've not had chance to test this yet but suspect that @ShyZhen is right, and we need to re-evaluate this for Windows users

No update on this yet. I am leaning towards removing these checks but am torn. I need to take a look at the history of this being introduced. We will...

Hi @sg3s - sorry for the delay in responding. The library aims to conform to spec as much as possible. While I can see the benefits of some of the...

I see where you are coming from now. I suppose my main reservation is that according to the spec, the issuing of a refresh token is usually at the discretion...

I think it would be good to work towards this so would hope for it to be included in the future. Thanks for the suggestion

Hi @jacobweber - this is definitely something I would like to add to the server so please feel free to submit a PR. Thanks!