Andrew Millington comments

Results 186 comments of


                                            Andrew Millington

Fix PHP 8.1 deprecations.

Resolved in #1329 so marking as closed. Thank you for alerting me to this and your suggested PR

AccessTokenTrait::__toString gives different result each call

Thanks for pointing this out. I'd never really thought that the to string method might be called more than once but makes total sense. I will get a fix out...

RefreshTokenGrant requires client_secret also for non-confidential clients

Could you provide details about where the exception is being thrown from and we can check this. It should be noted that most implementations don't allow public clients to use...

Race condition when issuing access token from authorization code

This is unfortunately not an easy fix. The problem here is that the access token generation can fail. If we revoke the auth code _before_ the access token is generated,...

Race condition when issuing access token from authorization code

Ok I will flag this as something to fix. I think you're right, we would likely have to have a temp hold on using the auth code until either the...

Wrong Type in DocBlock 3rd param `AbstractGrant::issueAccessToken`

Thanks for reporting this. It should be fixed in #1402

Add OpenID Response Type

Thanks for this PR. I am a bit stumped as to why the tests aren't running in this PR. Everything looks ok to me. Do you have any ideas? If...

Add OpenID Response Type

> Thanks for this PR. I am a bit stumped as to why the tests aren't running in this PR. Everything looks ok to me. Do you have any ideas?...

Add OpenID Response Type

Version 9 bringing in the device code is being worked on just now. Then I will start to look at other features. V9 RC1 should be tagged today all being...

Add support for RFC8693 - token exchange

Definitely interested in an implementation. The problem I have just now is trying to get a new main version out which is unfortunately taking up most of my time but...