Andrew Millington

Results 186 comments of Andrew Millington

Closing as added work to a diff branch now

The fix in #368 resolves this for me

Thanks so much for this @hafezdivandari. This is super useful. I suspected the change of IDs might cause issues downstream so great to have something concrete to work with. Really...

I think I've fixed all the issues raised here now @hafezdivandari - thanks again for creating the PR for Passport. Would you be able to check if this has resolved...

I can see the case for this argument. Part of the reason I originally had the identifiers as strings initially was to avoid casting when things come in from http...

Changes made now @hafezdivandari - if you can see how you get on with the PR, I can merge this into main assuming all is ok. Apologies for the delay...

It was great thank you. Thanks for spotting that. I've fixed the issue reported now.

I am also encountering this bug. The load event never triggers and the browser just hangs with a white page. All other browsers run fine. Interestingly, this doesn't seem to...

Hi @ajuszczyk - thanks for the PR. Because this is a public repo, we need to log information about the changes for future users/maintainers. Please could you like this to...

Have created PR #1329 which I think will address the issues. In a real world application, `validateAuthorizationRequest` and `completeAuthorizationRequest` should be called in tandem and the former prevents a null...