Jacob B. Sanders

Results 16 comments of Jacob B. Sanders

Note that the following PR is also open: - https://github.com/nodegit/nodegit/pull/1920/commits/89bb003237f842479915e610254c275d7b566458 ~***Accepting that PR will break usage***. It seems our friend didn't test his changes.~ I'm actually unsure if version `11`...

Testing the changes, in the unit-test: ``` // ... blah blah blah [Symbol(kOutHeaders)]: [Object: null prototype] { 'x-powered-by': [ 'X-Powered-By', 'Express' ], 'set-cookie': [ 'Set-Cookie', 'sid=; Path=/admin; Expires=Thu, 01 Jan...

Nice, seems to have passed

@bozzelliandrea, thank you for the feedback; I've since updated with your [recommended changes](https://github.com/expressjs/express/pull/4942/commits/bd67010a156cb8747f56f6954c5d1705d78bdda3), and point of replacing [`require` with `import`](https://github.com/expressjs/express/pull/4942/commits/18fa4f8d470dd47a4017533907178aa9d93bb0f4). Sorry my response took so long, I'll try and get...

> @Segmentational everything looks ok and clean, nice work! 😃 > > Just my curiosity, what does CJS mean? @bozzelliandrea, sorry for the delayed response... I just moved halfway across...

Added a review for [tgarbo's PR](https://github.com/expressjs/express/pull/4852)

@aravindvnair99 Oh haha I added those fields as I could check them off once I saw that I was added -- but I definitely see why that would be misleading...

Hey, guys, I have a few things for us In reference to a task [previously asked](https://github.com/expressjs/express/discussions/4762#discussioncomment-1688972) of, from @aravindvnair99, > Hey `@Segmentational!` > > Thanks for your interest! Apart from...

> [...] which is more efficient long term I'd be careful with this idea; while I'm of belief efficiency comes down to the team and what's therefore best for the...

Lastly, as I recommended against using classes, this is because there needs to be a running list, per instance, of applicable functions to call. This is due to the router...