Sebastiaan Dammann

Results 175 comments of Sebastiaan Dammann

I prefer explicit semicolons over automatic semicolon insertion. The reason is that the latter may be [ambiguous](https://stackoverflow.com/q/34950322/646215) ([another example](http://lucumr.pocoo.org/2011/2/6/automatic-semicolon-insertion/)), so in some situations you are required to use semicolons. In...

I understand that. You would still need to configure prettier to use the current coding standard as much as possible, otherwise the noise in the diff will be too high,...

@caseyWebb Thanks. I'm unable to get actual compilation of Typescript working with the current configuration. So I could definitely use some help there :) It appears Rollup is currently configured...

It is not typed, you don't provide types for input parameters and output type. It's like there can be a function that get any parameters of `any` and might or...

Yes, but you can model it as a type alias or interface for reusability and clarity if suitable. For instance: ``` type SubscriptionCallback = (newValue : T) => void; //...

Are you looking for [this](http://www.typescriptlang.org/docs/handbook/functions.html#this)? Any reason why `Observable` is not generic?

> > > > Any reason why `Observable` is not generic? > > Just because I don't yet know what generic means :) Ah, right, excuse me 😉 So currently...

In Typescript accessors on the object itself are not supported in ES3. This is not suprising, as accessors cannot be polyfilled in ES6. Take this for instance, in `tko/utils/options`: Object.defineProperty(options,...

> The one unknown is what issues crop up with the Typescript transpilation. As long as we're targeting ES3 I expect no issues. However, I believe we can safely target...

For what its worth I have a repo with 10k commits where loading the commit graph takes mere seconds, and I have repositories with barely 1.6k commits where loading the...